Release r2.1 with NSB v0.2.0-rc.1 and NSA v0.1.0-rc.1#93
Release r2.1 with NSB v0.2.0-rc.1 and NSA v0.1.0-rc.1#93XunliYang wants to merge 4 commits intocamaraproject:mainfrom
Conversation
tanjadegroot
left a comment
There was a problem hiding this comment.
Hi all,
quite some comments on the new API
I recommend to
- change this to a DRAFT Release PR, do the changes on main in normal PRs.
- wait for the Release PRs of Commonalities and ICM to be available and do the relevant adjustments (if any)
- then re-open and resynch the Release PR only after all required changes are done
documentation/API_documentation/network-slice-assignment-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/network-slice-assignment-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/network-slice-booking-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
|
@tanjadegroot, thanks for your review. We have addressed comments and updated the code accordingly. Please take another look when you have a moment. Most of problems are fixed in [Modify network-slice-assignment API Path and Feature Files #96](#96):
Version problems are modified in this PR:
|
tanjadegroot
left a comment
There was a problem hiding this comment.
Looks great ! thanks for the updates.
For Spring26 release, final Release PR needs to be resynch to Spring26 Release PR of Commonalities and ICM
|
|
||
| The API definition(s) are based on | ||
|
|
||
| - Commonalities v1.0.0 |
There was a problem hiding this comment.
| - Commonalities v1.0.0 | |
| - Commonalities v0.7.0 |
|
|
||
| The API definition(s) are based on | ||
|
|
||
| - Commonalities v1.0.0 |
There was a problem hiding this comment.
For the final Release PR, the API needs to be aligned with the Spring26 Commonalities version. you can find here the changes that may apply: https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/518225924/Analysis+of+Commonalities+0.7.0-rc.1
such changes would need to be applied on main and resynched before the final Release PR
There was a problem hiding this comment.
And same for ICM Spring26 release.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Release r2.1 with network-slice-booking v0.2.0-rc.1 and network-slice-assignment v0.1.0-rc.1
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input